Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/link: regression introduced with golang.org/cl/69370 on ppc64le #22250
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
CL 69370 introduced a hasmain field to moduledata after the modulehashes slice. However that code was relying on the zeroing code after it to cover modulehashes if len(Shlibs) == 0. The hasmain field gets in the way of that. So clear modulehashes explicitly in that case. Found when looking at #22250. Not sure if it's related. Change-Id: I81050cb4554cd49e9f245d261ef422f97d026df4 Reviewed-on: https://go-review.googlesource.com/70730 Run-TryBot: David Crawshaw <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Ian Lance Taylor <firstname.lastname@example.org>
The failure is on the test case added in guilty commit, CL 69370. I am assuming the underlying cause of the failure was pre-existing on linux/ppc64le, we just didn't have a test to see it.
So if you need a quick fix for the builder, we can disable the test on ppc64le. Otherwise I'm going to keep staring at it and see if I can find the underlying problem. (Made a bit difficult by the fact I don't have one of these machines.)