Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: regression introduced with golang.org/cl/69370 on ppc64le #22250

Closed
laboger opened this issue Oct 13, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@laboger
Copy link
Contributor

commented Oct 13, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go tip

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

ppc64le Ubuntu any

What did you do?

Saw ppc64le failures on golang.org/build

What did you expect to see?

ok

What did you see instead?

Output from the log:

../misc/cgo/testplugin

PASS
something
fatal error: runtime: plugin has empty pluginpath

goroutine 1 [running]:
runtime.throw(0x10151c61, 0x24)
/tmp/workdir/go/src/runtime/panic.go:616 +0x68 fp=0xc420047a30 sp=0xc420047a00 pc=0x1008e5a8
plugin.lastmoduleinit(0x10130780, 0x0, 0x0, 0xc420068150, 0x1020bb20)
/tmp/workdir/go/src/runtime/plugin.go:23 +0x9cc fp=0xc420047b60 sp=0xc420047a30 pc=0x1008f73c
plugin.open(0x1014ec73, 0x12, 0x100bcd50, 0x10069bfc, 0xc4200680f0)
/tmp/workdir/go/src/plugin/plugin_dlopen.go:118 +0x32c fp=0xc420047e50 sp=0xc420047b60 pc=0x1011038c
plugin.Open(0x1014ec73, 0x15, 0x1010f510, 0x1014d129, 0x10111140)
/tmp/workdir/go/src/plugin/plugin.go:32 +0x34 fp=0xc420047e98 sp=0xc420047e50 pc=0x1010f924
main.main()
/tmp/workdir/go/misc/cgo/testplugin/src/issue22175/main.go:14 +0x3c fp=0xc420047f58 sp=0xc420047e98 pc=0x1011119c
runtime.main()
/tmp/workdir/go/src/runtime/proc.go:195 +0x1fc fp=0xc420047fc0 sp=0xc420047f58 pc=0x100907ec
runtime.goexit()
/tmp/workdir/go/src/runtime/asm_ppc64x.s:1353 +0x4 fp=0xc420047fc0 sp=0xc420047fc0 pc=0x100b7c94
2017/10/13 01:19:27 Failed: exit status 2
2017/10/13 01:19:27 FAILED

@gopherbot

This comment has been minimized.

Copy link

commented Oct 13, 2017

Change https://golang.org/cl/70730 mentions this issue: cmd/link: zero symtab fields correctly

gopherbot pushed a commit that referenced this issue Oct 13, 2017

cmd/link: zero symtab fields correctly
CL 69370 introduced a hasmain field to moduledata after the
modulehashes slice. However that code was relying on the zeroing
code after it to cover modulehashes if len(Shlibs) == 0. The
hasmain field gets in the way of that. So clear modulehashes
explicitly in that case.

Found when looking at #22250. Not sure if it's related.

Change-Id: I81050cb4554cd49e9f245d261ef422f97d026df4
Reviewed-on: https://go-review.googlesource.com/70730
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@crawshaw

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

The failure is on the test case added in guilty commit, CL 69370. I am assuming the underlying cause of the failure was pre-existing on linux/ppc64le, we just didn't have a test to see it.

So if you need a quick fix for the builder, we can disable the test on ppc64le. Otherwise I'm going to keep staring at it and see if I can find the underlying problem. (Made a bit difficult by the fact I don't have one of these machines.)

@gopherbot

This comment has been minimized.

Copy link

commented Oct 13, 2017

Change https://golang.org/cl/70810 mentions this issue: cmd/link: use the correct module data on ppc64le

@gopherbot gopherbot closed this in c996d07 Oct 13, 2017

@golang golang locked and limited conversation to collaborators Oct 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.