Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upproposal: net/http: Proxy: Support authentication that takes multiple rounds #22288
Labels
Milestone
Comments
ianlancetaylor
changed the title
This comment has been minimized.
This comment has been minimized.
|
CC @tombergan |
This comment has been minimized.
This comment has been minimized.
|
Can you explain why you cannot use a custom dialer as Brad suggested here? |
This comment has been minimized.
This comment has been minimized.
|
I can use a custom dialer as Brad suggested: |
This comment has been minimized.
This comment has been minimized.
|
In that case I'd prefer to close this request. NTLM is a specific and narrow use case. It does not seem worth adding API for this one use case. If it turns out there many other protocols that use multi-round authentication, we can reconsider. |
gogolok
added a commit
to anynines/cli-OLD
that referenced
this issue
Nov 17, 2017
…variable Go does not support NTLM proxy authentication by default. An attempt golang/go#22288 to add NTLM proxy authentication to Go's code base has not been accepted. But there is a workaround/hack overwriting http.Transport.DialContext to do NTLM proxy authentication. Experimental: Returns NTLM proxy authentication handler if NTLM_PROXY is set. The environment variable NTLM_PROXY contains the proxy to be used. Works on Windows only.
gogolok
added a commit
to anynines/cli-OLD
that referenced
this issue
Nov 17, 2017
…variable Go does not support NTLM proxy authentication by default. An attempt golang/go#22288 to add NTLM proxy authentication to Go's code base has not been accepted. But there is a workaround/hack overwriting http.Transport.DialContext to do NTLM proxy authentication. Experimental: Returns NTLM proxy authentication handler if NTLM_PROXY is set. The environment variable NTLM_PROXY contains the proxy to be used. Works on Windows only.
gogolok
added a commit
to anynines/cli-OLD
that referenced
this issue
Nov 17, 2017
…variable Go does not support NTLM proxy authentication by default. An attempt golang/go#22288 to add NTLM proxy authentication to Go's code base has not been accepted. But there is a workaround/hack overwriting http.Transport.DialContext to do NTLM proxy authentication.
gogolok
added a commit
to anynines/cli-OLD
that referenced
this issue
Nov 17, 2017
…variable Go does not support NTLM proxy authentication by default. An attempt golang/go#22288 to add NTLM proxy authentication to Go's code base has not been accepted. But there is a workaround/hack overwriting http.Transport.DialContext to do NTLM proxy authentication.
gogolok
added a commit
to anynines/cli-OLD
that referenced
this issue
Nov 17, 2017
…variable Go does not support NTLM proxy authentication by default. An attempt golang/go#22288 to add NTLM proxy authentication to Go's code base has not been accepted. But there is a workaround/hack overwriting http.Transport.DialContext to do NTLM proxy authentication.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The Go http client lacks support for proxy authentication that takes multiple rounds, see for example #20053 . This prohibits support for a wider range of proxy authentications, for example NTLM proxy authentication.
Current issues trying to use NTLM proxy authentication:
I suggest to make the proxy connection setup customisable.
One could extend the
Transportto specify a setup function to configure the proxy connection:A context (in this example
ProxySetupContext) needs to provide all necessary information to setup a proxy connection, that is:httpvs.httpsnet.Conn)A default proxy setup function would be provided. The default proxy setup function would handle the HTTPS+CONNECT case.
An attempt :