/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestLldbPython test fails with lldb 3.8 on linux #22299

Open
hyangah opened this Issue Oct 16, 2017 · 4 comments

Comments

Assignees
No one assigned
Labels
NeedsFix Testing help wanted
Projects
None yet
Milestone
  Go1.12
6 participants
@hyangah @mvdan @ianlancetaylor @gopherbot @ALTree @rsc
@hyangah
Contributor

hyangah commented Oct 16, 2017

Verified the test passed with lldb 3.9 or higher, or if lldb is not installed at all.

--- FAIL: TestLldbPython (1.83s)
runtime-lldb_test.go:178: Unexpected lldb output:
Created target
Created breakpoint
Process launched
Hit breakpoint
Stopped at main.go:10
Stopped in main.main
no intvar
FAIL
FAIL runtime 19.046s

Skipping the test if lldb is too ancient seems reasonable.

@ianlancetaylor ianlancetaylor added this to the Go1.10 milestone Oct 16, 2017

@ianlancetaylor ianlancetaylor added Testing NeedsFix labels Oct 16, 2017

@mvdan

This comment has been minimized.

Sign in to view
Member

mvdan commented Oct 29, 2017

The lldb tests are already skipped if it or python are not available. Would an additional version check to ensure version 3.9 or later is available be an OK fix for this?

@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017

@ianlancetaylor ianlancetaylor added the help wanted label Jul 7, 2018

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jul 7, 2018

@ianlancetaylor

This comment has been minimized.

Sign in to view
Contributor

ianlancetaylor commented Jul 7, 2018

Yes, checking the lldb version sounds like a good fix.
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Oct 3, 2018

Change https://golang.org/cl/139397 mentions this issue: runtime: skip TestLldbPython when lldb is too old

@gopherbot gopherbot closed this in d217004 Oct 4, 2018

@ALTree

This comment has been minimized.

Sign in to view
Member

ALTree commented Oct 5, 2018

FIx was reverted: https://go-review.googlesource.com/c/go/+/140217

@ALTree ALTree reopened this Oct 5, 2018

@agnivade agnivade referenced this issue Dec 14, 2018

Open

runtime: TestLldbPython fails for lldb 7.0.0 #29244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment