Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: staging environment doesn’t run current version #22437

Open
andybons opened this issue Oct 25, 2017 · 1 comment

Comments

@andybons
Copy link
Member

commented Oct 25, 2017

When running coordinator on the go-dashboard-dev project (our staging environment), it panics:

2017/10/25 17:24:24 Running in prod mode
panic: unknown builder "windows-386-gce"

goroutine 1 [running]:
main.stagingClusterBuilders(0x8)
	/go/src/golang.org/x/build/cmd/coordinator/coordinator.go:396 +0x527
main.main()
	/go/src/golang.org/x/build/cmd/coordinator/coordinator.go:318 +0xc50

This appears to be an issue with the environment and not the binary logic.

/cc @adams-sarah

@gopherbot gopherbot added this to the Unreleased milestone Oct 25, 2017

@gopherbot gopherbot added the Builders label Oct 25, 2017

@adams-sarah

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

Oh it is in the binary.

See
https://github.com/golang/build/blob/master/cmd/coordinator/coordinator.go#L391

The set of (hard-coded) staging builders is out of date. There is no longer any builder called "windows-386-gce".
The string should just be update to "windows-386-2008" or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.