Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: can't specify pprof symbolz endpoint #22483

Closed
anacrolix opened this issue Oct 29, 2017 · 3 comments
Closed

cmd/pprof: can't specify pprof symbolz endpoint #22483

anacrolix opened this issue Oct 29, 2017 · 3 comments

Comments

@anacrolix
Copy link
Contributor

@anacrolix anacrolix commented Oct 29, 2017

There's no option with go tool pprof to specify the endpoint for the symbols. The current method to derive it from the profile path isn't very flexible, such as when the debug/pprof endpoints are wrapped into a deeper path, for example /some/wrapping/path/debug/pprof/. In this case, pprof determines that the symbols will be at /symbolz, when in fact they should be at /some/wrapping/path/debug/pprof/symbol.

@gbbr gbbr changed the title Can't specify pprof symbolz endpoint cmd/pprof: can't specify pprof symbolz endpoint Oct 30, 2017
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Oct 31, 2017

@hyangah
Copy link
Contributor

@hyangah hyangah commented Nov 6, 2017

@anacrolix Given that your PR in google/pprof was merged, is it sufficient if the vendor'ed pprof source is updated? If not, please file an issue to google/pprof.

https://golang.org/cl/75870 update the vendored pprof source recently and should include the PR.

BTW, in what case you will need symbol lookup? My understanding is that go runtime pprof outputs already include symbol info, so pprof would not require extra symbol lookups in most cases. Otherwise, something is not working as intended.

@anacrolix
Copy link
Contributor Author

@anacrolix anacrolix commented Nov 7, 2017

It does appear the fixes were merged in aec345d.

Some of the pprof endpoints seem to require the symbols endpoint too. I don't know why this is the case, it appears to be some kind of optimization.

@anacrolix anacrolix closed this Nov 7, 2017
@golang golang locked and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.