Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/internal/obj/arm64: reduce verbosity of code in /obj/arm64/asm7.go #22576
This is my first attempt at contributing to the Go source code, I am very open to suggestions to improving my process.
I submitted a patch to gerrit and was asked by Brad Fitzpatrick (who kindly reviewed the code) to create a corresponding bug.
This is the issue that I believed can be improved by my patch:
Here's the change: 75690
I've edited the title of the issue because based on your comments on the CL
this is just about deciding whether it's worth changing the code to make it more readable, and you are not reporting compiler bug(?)
No, many of us would argue strongly that that assumption is not true. For example, 5 tricky lines are more likely to hide a bug than 10 boring lines.
That said, your change might be an improvement, but I'll let others decide. I just wanted to clarify that reducing the number of lines is not a goal in and of itself.