Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vendor/github.com/google/pprof/internal/driver: TestHttpsInsecure fails #22594

Open
alexbrainman opened this issue Nov 6, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@alexbrainman
Copy link
Member

commented Nov 6, 2017

What version of Go are you using (go version)?

go version devel +bb98331 Mon Nov 6 01:35:58 2017 +0000 windows/386

What operating system and processor architecture are you using (go env)?

Windows XP 32 bit

set GOARCH=386
set GOBIN=
set GOCACHE=go-build
set GOEXE=.exe
set GOHOSTARCH=386
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Documents and Settings\aa\dev\
set GORACE=
set GOROOT=C:\Documents and Settings\aa\dev\go
set GOTMPDIR=
set GOTOOLDIR=C:\Documents and Settings\aa\dev\go\pkg\tool\windows_386
set GCCGO=gccgo
set GO386=sse2
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m32 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\DOCUME~1\aa\LOCALS~1\Temp\go-build119289778=/tmp/go-build -gno-record-gcc-switches

What did you do?

I run

go test -short -v -run=TestHttpsInsecure cmd/vendor/github.com/google/pprof/internal/driver

command

What did you expect to see?

PASS

What did you see instead?

=== RUN   TestHttpsInsecure
--- FAIL: TestHttpsInsecure (15.11s)
        fetch_test.go:420: fetchProfiles(https+insecure://127.0.0.1:2343/debug/pprof/profile) got non-symbolized profile: len(p.Function)==0
FAIL
exit status 1
FAIL    cmd/vendor/github.com/google/pprof/internal/driver      15.261s

Alex

@ALTree

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

It had the same issue on plan9, and it's now skipped on plan9 (see https://github.com/google/pprof/blob/79c4198ef7bd1069f8f56501fc05f0f1d2c33d8a/internal/driver/fetch_test.go#L426). We could add XP detection and Skip there, too.

That said, I was surprised to learn that we still support Windows XP (we don't even have a builder for it: #10267; breakage seems inevitable). @alexbrainman Out of curiosity, is there any plan to phase off XP support?

@ALTree ALTree added the Testing label Nov 6, 2017

@ALTree ALTree added this to the Go1.10 milestone Nov 6, 2017

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2017

It had the same issue on plan9, and it's now skipped on plan9

I did not have a chance to investigate this yet. Do you know what is broken?

@alexbrainman Out of curiosity, is there any plan to phase off XP support?

I do not run Windows XP any more. But once in a while I turn my old computer on only to discover that Go still works on it (including running all.bat). So there is very little "maintenance" on my part. We can declare Windows XP as not supported, but what are we to gain from that?

Alex

@ALTree

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

Do you know what is broken?

AFAIK CPU profiling just doesn't work on a few system/kernels, so returned profiles are empty and the test fails. We have #13841 for this, but Windows is not mentioned here. I don't know if the root cause is the same as the one mentioned there.

We can declare Windows XP as not supported, but what are we to gain from that?

That we won't have to debug and fix issues like this one any more : ) Jokes aside, I have nothing against Go still officially supporting Windows XP, I don't see many XP-related bugs filed here so it's not like XP support requires a significant amount of work.

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2017

AFAIK CPU profiling just doesn't work on a few system/kernels, so returned profiles are empty and the test fails. We have #13841 for this, but Windows is not mentioned here. I don't know if the root cause is the same as the one mentioned there.

Thanks for the info. I will have a look when I get around to it.

Alex

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

I actually worked on the Windows XP builder recently. I don't have it online yet, though.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Unplanned Dec 6, 2017

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2017

FYI. This is how this failure looks now (go version devel +840fad1 Fri Dec 8 21:34:24 2017 +0000 windows/386):

Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto692695659
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output515286222
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto843567573
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output224173872
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto773020367
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output041979362
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto888498649
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output023426916
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto067212659
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output396533302
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto919268381
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output361080024
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto110886999
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output019404234
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto066471073
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output958677900
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto160214395
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output065365662
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto594469733
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output820835200
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto448383199
Hide expression matched no samples
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output835759794
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto551871593
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output975475892
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto600751235
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output587553286
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto942780333
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output181980456
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto873942631
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output538548890
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto919414065
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output503070940
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto785010315
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output731650158
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto131466485
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output681117648
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto979284207
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output725014402
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto779629817
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output851461636
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto489463187
Ignoring local file \path\to\buildid-contention: build-id mismatch (buildid-contention != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output788932566
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto066206013
Ignoring local file \path\to\buildid-contention: build-id mismatch (buildid-contention != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output141312888
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto417937527
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output033166186
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto493068225
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output769530924
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto407154587
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output228292670
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto386990213
TagHide expression matched no samples
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output832611872
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto617105663
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output352665170
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto890350985
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output870522708
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto822884515
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output380400550
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto059814093
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output264667080
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto808290439
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output885106746
TagShow expression matched no samples
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto998080081
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
TagShow expression matched no samples
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output759434108
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto211531435
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output251788814
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto794351125
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
tagfocus:Interpreted '1mb:2gb' as range, not regexp
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output961803888
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto865960719
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef)
tagfocus:Interpreted '30kb:' as range, not regexp
tagignore:Interpreted '1mb:2mb' as range, not regexp
TagHide expression matched no samples
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output154357538
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto295762969
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output373042852
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto399778227
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output943696246
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto697677917
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output234969624
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_proto054917783
Ignoring local file \path\to\buildid: build-id mismatch (buildid != abcdef) tagfocus:Interpreted '400kb:' as range, not regexp
Generating report in C:\DOCUME~1\aa\LOCALS~1\Temp\profile_output161258762
Local symbolization failed for cppbench_server_main: CreateFile cppbench_server_main: The system cannot find the file specified.
Local symbolization failed for libpthread-2.15.so: CreateFile /libpthread-2.15.so: The system cannot find the file specified.
Some binary filenames not available. Symbolization may be incomplete.
Try setting PPROF_BINARY_PATH to the search path for local binaries.
Local symbolization failed for cppbench_server_main: CreateFile cppbench_server_main: The system cannot find the file specified.
Local symbolization failed for libpthread-2.15.so: CreateFile /libpthread-2.15.so: The system cannot find the file specified.
Some binary filenames not available. Symbolization may be incomplete.
Try setting PPROF_BINARY_PATH to the search path for local binaries.
Local symbolization failed for cppbench_server_main: CreateFile cppbench_server_main: The system cannot find the file specified.
Local symbolization failed for libpthread-2.15.so: CreateFile /libpthread-2.15.so: The system cannot find the file specified.
Some binary filenames not available. Symbolization may be incomplete.
Try setting PPROF_BINARY_PATH to the search path for local binaries.
--- FAIL: TestHttpsInsecure (15.13s)
        fetch_test.go:442: fetchProfiles(https+insecure://127.0.0.1:4847/debug/p
prof/profile) got non-symbolized profile: len(p.Function)==0
FAIL
FAIL    cmd/vendor/github.com/google/pprof/internal/driver      18.024s

Alex

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 9, 2017

The linux-arm-arm5spacemonkey builder also fails in the same way with this pprof failure:

https://build.golang.org/log/a73a8e17687b9a1bc3d429223d883e837a73f32a

@ALTree

This comment has been minimized.

Copy link
Member

commented Dec 9, 2017

@alexbrainman That's the same failure (with the same error message) reported in the first message... what am I missing? The part above the --- FAIL: line is verbose output from previous tests I think.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 10, 2017

Change https://golang.org/cl/83115 mentions this issue: dashboard: don't snapshot XP builders (not shared anyway), and skip pprof tests

gopherbot pushed a commit to golang/build that referenced this issue Dec 10, 2017

dashboard: don't snapshot XP builders (not shared anyway), and skip p…
…prof tests

Updates golang/go#10267
Updates golang/go#22594

Change-Id: Ib6a9e13fbaaf4aad0b74008146b55e651658d4dd
Reviewed-on: https://go-review.googlesource.com/83115
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@gopherbot

This comment has been minimized.

Copy link

commented Dec 14, 2017

Change https://golang.org/cl/84035 mentions this issue: dashboard: give openbsd/386 more time, and skip pprof vendor tests on arm5

gopherbot pushed a commit to golang/build that referenced this issue Dec 14, 2017

dashboard: give openbsd/386 more time, and skip pprof vendor tests on…
… arm5

Updates golang/go#19547
Updates golang/go#22594

Change-Id: I0200eebf39c1fada6c6ce146afacb9d140142c5b
Reviewed-on: https://go-review.googlesource.com/84035
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

aalexand added a commit to aalexand/pprof that referenced this issue Mar 31, 2018

Switch to use goroutine profile in TestHttpsInsecure.
Trying to test against /debug/pprof/profile has been giving some flakes
and trouble so far (google#146, google#253, google#328, golang/go#24611, golang/go#22594). While
some of the discussions the failures triggered appear to be useful (such
as whether CPU profiles are expected to be working on Windows XP or
not), that kind of testing is not really in the scope for this
particular test. This change switches the test to use goroutine profile
instead which is hopefully much less dependent on the environment. The
change also makes the test much faster to run.

nolanmar511 added a commit to google/pprof that referenced this issue Apr 2, 2018

Switch to use goroutine profile in TestHttpsInsecure. (#350)
Trying to test against /debug/pprof/profile has been giving some flakes
and trouble so far (#146, #253, #328, golang/go#24611, golang/go#22594). While
some of the discussions the failures triggered appear to be useful (such
as whether CPU profiles are expected to be working on Windows XP or
not), that kind of testing is not really in the scope for this
particular test. This change switches the test to use goroutine profile
instead which is hopefully much less dependent on the environment. The
change also makes the test much faster to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.