Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: Gerrit CL deletions are not reflected in model #22635

Open
andybons opened this issue Nov 8, 2017 · 3 comments
Open

x/build/maintner: Gerrit CL deletions are not reflected in model #22635

andybons opened this issue Nov 8, 2017 · 3 comments
Labels
Milestone

Comments

@andybons
Copy link
Member

@andybons andybons commented Nov 8, 2017

on https://dev.golang.org/release, search for Copybaraimportfromhttps. It shows CLs that have been deleted:

Copybaraimportfromhttps
  CL 72110 Copybara import from https://github.com/golang/scratch/pull/2 .
  CL 72131 Copybara import from https://github.com/golang/scratch/pull/2.
PRESUBMITforCopybarahttps
  CL 72090 PRESUBMIT for Copybara https://github.com/golang/scratch/pull/2 .
  CL 72091 PRESUBMIT for Copybara https://github.com/golang/scratch/pull/2 .

These are pulled in via ForeachOpenCL.

/cc @kevinburke @bradfitz

@dmitshur

This comment was marked as resolved.

Copy link
Member

@dmitshur dmitshur commented Jan 22, 2019

I mistakenly thought this issue was also about branch deletions not being reflected, but I just noticed that's not described in this issue. Does anyone know if branches are indeed also affected? If not, I'll investigate and report back. /cc @FiloSottile

Edit: I found the issue I was looking for, it was #23099. Please disregard this comment.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented May 8, 2019

Change https://golang.org/cl/176038 mentions this issue: cmd/gopherbot: add map of deleted scratch CLs to prevent bad API calls

gopherbot pushed a commit to golang/build that referenced this issue Sep 13, 2019
Updates golang/go#22635
Updates golang/go#28320

Change-Id: I8769dc83187ad1b1b2c1d751818964565f34e6d3
Reviewed-on: https://go-review.googlesource.com/c/build/+/176038
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 1, 2019

Change https://golang.org/cl/198118 mentions this issue: devapp: add CL 93515 to deleted list

gopherbot pushed a commit to golang/build that referenced this issue Oct 1, 2019
Updates golang/go#22635

Change-Id: I5dc62ddda0bb54eef0c833a8ea66de3349a7871d
Reviewed-on: https://go-review.googlesource.com/c/build/+/198118
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
Updates golang/go#22635
Updates golang/go#28320

Change-Id: I8769dc83187ad1b1b2c1d751818964565f34e6d3
Reviewed-on: https://go-review.googlesource.com/c/build/+/176038
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
Updates golang/go#22635

Change-Id: I5dc62ddda0bb54eef0c833a8ea66de3349a7871d
Reviewed-on: https://go-review.googlesource.com/c/build/+/198118
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.