Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/mail: missing date layout #22661

wxdao opened this issue Nov 10, 2017 · 5 comments


None yet
7 participants
Copy link

commented Nov 10, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.9.1 darwin/amd64

Does this issue reproduce with the latest release?


What did you do?


In net/mail/message.go there is

zones := [...]string{"-0700", "MST", "-0700 (MST)"}

However, it leaves out the situation -0700 (GMT:-07:00).

So, rewriting that line to

zones := [...]string{"-0700", "MST", "-0700 (MST)", "-0700 (GMT:-07:00)"}

would fix this issue.

What did you expect to see?

It gets parsed successfully.

What did you see instead?

0001-01-01 00:00:00 +0000 UTC mail: header could not be parsed

@ianlancetaylor ianlancetaylor changed the title missing date layout in net/mail net/mail: missing date layout Nov 10, 2017

@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone Nov 10, 2017


This comment has been minimized.

Copy link

commented Nov 10, 2017

Where did you see this date header?

From looking at RFC 5322 I suspect that the right fix is to remove "-0700 (MST)" from dateLayouts and to change ParseDate to skip CFWS at the end.


This comment has been minimized.

Copy link

commented Nov 11, 2017


This comment has been minimized.

Copy link

commented Jun 9, 2018

Change mentions this issue: net/mail: added support to trailing CFWS in date


This comment has been minimized.

Copy link

commented Jun 9, 2018

RFC 5322 date format always finishes with a time zone. Checking the ending allows to discard the trailing CFWS as per standard.


This comment has been minimized.

Copy link

commented Jun 22, 2018

As per @ianlancetaylor's comments in the review of CL 117596, that this change is more complicated than permissible this late in the cycle, we are moving this to Go1.12.

@odeke-em odeke-em modified the milestones: Go1.11, Go1.12 Jun 22, 2018

@bcmills bcmills modified the milestones: Go1.12, Go1.13 Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.