Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: hide all-red builders #22689

Closed
rsc opened this issue Nov 13, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@rsc
Copy link
Contributor

commented Nov 13, 2017

The columns of red on the dashboard should be fixed or removed from the default display. As things are now, the fact that we apparently expect some builders to be all red hides the fact that we don't expect other builders to be all red.

Right now, linux-amd64-alpine, linux-amd64-noopt, and linux-arm-arm5spacemonkey are all red. Apparently alpine and monkey are expected to be that way - there are long-term bugs open for fixing those - but noopt is not expected to be that. It looks like I broke noopt in CL 74470, but I didn't notice because it just added one more all-red column to the dashboard.

We should make it the case that all-red is always something that needs attention now, not a "would be nice" for the future.

/cc @bradfitz

@rsc rsc added this to the Go1.10 milestone Nov 13, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 13, 2017

Sounds good. But alpine and plan9-amd64 are the one two I'd expect to be read.

spacemonkey shouldn't be broken?

/cc @0intro @zeebo

@bradfitz bradfitz added the Builders label Nov 13, 2017

@bradfitz bradfitz changed the title build: hide all-red builders x/build: hide all-red builders Nov 13, 2017

@zeebo

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

I also expect they (spacemonkey builders) should be working.

@0intro

This comment has been minimized.

Copy link
Member

commented Nov 13, 2017

I've fixed the plan9-amd64 builder a while ago, so it should be fine.

However, the plan9-arm builder is currently red because of an issue raised by TestHttpsInsecure after the update of the github.com/google/pprof/internal/driver package (issue #22691).

@randall77

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Nov 18, 2017

Change https://golang.org/cl/78575 mentions this issue: dashboard: remove alpine builder

gopherbot pushed a commit to golang/build that referenced this issue Nov 18, 2017

dashboard: remove alpine builder
It's doing no good being red all the time, especially as nobody is
working on it.

Updates golang/go#22689
Updates golang/go#19938

Change-Id: Icb947878d85e920f24ea458eb0f319844ca5bd60
Reviewed-on: https://go-review.googlesource.com/78575
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

I've fixed all the red that shouldn't be red.

The remaining red is real or has outstanding CLs waiting to be approved.

Closing this in favor of the specific bugs. Now that I'm back full-time, I'll be watching build.golang.org as usual.

@bradfitz bradfitz closed this Nov 28, 2017

@golang golang locked and limited conversation to collaborators Nov 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.