Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: dropped tests in CL 66870? #22708

Closed
rsc opened this issue Nov 14, 2017 · 3 comments
Closed

cmd/dist: dropped tests in CL 66870? #22708

rsc opened this issue Nov 14, 2017 · 3 comments

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Nov 14, 2017

I just posted a (late) comment on merged CL 66870. It seems to have dropped some tests in cmd/dist. If I'm confused, then great, close this issue. But if we really dropped some tests unintentionally, we should restore them and make sure they still pass.

@rsc rsc added this to the Go1.10 milestone Nov 14, 2017
@rsc rsc added the release-blocker label Nov 14, 2017
@laboger
Copy link
Contributor

@laboger laboger commented Nov 14, 2017

I'll check into it.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 14, 2017

Change https://golang.org/cl/77650 mentions this issue: cmd/dist: return dropped tests from misc/cgo/test

@laboger
Copy link
Contributor

@laboger laboger commented Nov 14, 2017

The original code in cmd/dist/test.go was using defaultcc and that was a string but was changed in the meantime to be a map of strings. I changed it to use defaultcc[""] but I'm not sure in all cases if that is correct.

@gopherbot gopherbot closed this in 12e2933 Nov 18, 2017
@golang golang locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.