Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
encoding/xml: possible bugs in xml.go #2271
I am neither a contributor nor a golang user, but perusing your code "xml.go" I have noticed the following possible inconsistencies: 1) RawToken () case '?' line 492 at first iteration "b0" value is undefined. (Should I trust the compiler to clear the locals?) 2) space () line 727: '\n' => line count should be increased 3) nsname () line 974: simple "return" does not transmit ok (redefined in 972)
1) yes, it's zero by default. the language defines that. 2) yes, getc does that 3) it's fine. a) they're in the same scope; it's not redefined. b) if it it were redefined, it's only returning on !ok, and would be returning false for ok. even it's a false from elsewhere, it's still false.
Status changed to Invalid.