Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: no trybot for compile-only linux/arm64 #22718

Closed
bradfitz opened this issue Nov 14, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Nov 14, 2017

I just submitted two arm64 CLs which don't even compile, but pass trybots:

https://go-review.googlesource.com/c/go/+/61570
https://go-review.googlesource.com/c/go/+/61550

I don't know why Trybots didn't catch this. I guess we no longer have linux/arm64 trybots.

/cc @zhangfannie @ianlancetaylor

@bradfitz bradfitz self-assigned this Nov 14, 2017

@gopherbot gopherbot added this to the Unreleased milestone Nov 14, 2017

@gopherbot gopherbot added the Builders label Nov 14, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Nov 14, 2017

Change https://golang.org/cl/77590 mentions this issue: crypto, internal/cpu: add noescape annotations, fix arm64 build

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2017

Actually, there is trybot coverage:

        addMiscCompile("", "^(linux-arm64|nacl-arm|solaris-amd64|darwin-386)$") // 4 ports                                                                
        addMiscCompile("-mips", "^linux-mips")                                  // 4                                                                      
        addMiscCompile("-ppc", "^linux-ppc64")                                  // 2                                                                      
        addMiscCompile("-plan9", "^plan9-")                                     // 3                                                                      
        addMiscCompile("-freebsd", "^freebsd-")                                 // 3                                                                      
        addMiscCompile("-netbsd", "^netbsd-")                                   // 3                                                                      
        addMiscCompile("-openbsd", "^openbsd-")                                 // 3                                                                      

These CLs were atop the necessary https://go.googlesource.com/go/+/ee50d79e8b1e14f1c867883be56dd821551cc7e4 but when I submitted, it cherry-picked to master.

Closing in favor of #22123 and #12482.

@bradfitz bradfitz closed this Nov 14, 2017

gopherbot pushed a commit that referenced this issue Nov 14, 2017

internal/cpu: fix arm64 build
I submitted two CLs which broke the build. Add temporary placeholder
with false bools to fix the build and restore old behavior.

Updates #22718 (details of why it broke)

Change-Id: I1f30624e14f631a95f4eff5aae462f1091f723a2
Reviewed-on: https://go-review.googlesource.com/77590
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@golang golang locked and limited conversation to collaborators Nov 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.