Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math/rand: revert Perm changes? #22744

Closed
rsc opened this issue Nov 15, 2017 · 3 comments
Closed

math/rand: revert Perm changes? #22744

rsc opened this issue Nov 15, 2017 · 3 comments

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Nov 15, 2017

I encouraged Josh to change Perm to match Shuffle, but it's a potentially breaking change and while writing the release notes I am reluctant to describe it. We should probably revert the behavioral change in Perm.

@rsc rsc added this to the Go1.10 milestone Nov 15, 2017
@rsc rsc added the release-blocker label Nov 15, 2017
@dsnet
Copy link
Member

@dsnet dsnet commented Nov 15, 2017

I support reverting rand.Perm changes. It is the cause of a few failures inside Google, and the fix for them is not easy.

@mvdan
Copy link
Member

@mvdan mvdan commented Nov 15, 2017

The CL in question is https://golang.org/cl/55972, if anyone was wondering (like myself).

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 16, 2017

Change https://golang.org/cl/78195 mentions this issue: Revert "math/rand: make Perm match Shuffle"

@gopherbot gopherbot closed this in d9a198c Nov 16, 2017
@golang golang locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.