Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/test2json: skipped tests never finish #22790

Closed
rsc opened this issue Nov 17, 2017 · 1 comment
Closed

cmd/test2json: skipped tests never finish #22790

rsc opened this issue Nov 17, 2017 · 1 comment
Labels
FrozenDueToAge release-blocker
Milestone
Go1.10

Comments

@rsc
Copy link
Contributor

rsc commented Nov 17, 2017

In the JSON stream, tests that end by skipping have a start (run) event but no end event. We need to define a skip ending event like pass/fail.
@rsc rsc added this to the Go1.10 milestone Nov 17, 2017
@gopherbot
Copy link

Change https://golang.org/cl/81535 mentions this issue: cmd/go: fix missing conversions in -json output

@golang golang locked and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@rsc @gopherbot