crypto/tls: TLS client handshake never times out

[bradfitz]

Forking off part of https://golang.org/issue/2263 ,

The TLS server handshake never times out if the underlying socket has a read timeout on
it.

readHandshake() in crypto/tls/conn.go loops forever, continually getting EAGAIN in
readRecord from readFromUntil.

I'm not sure the best place to fix.  I could do my own timeout up in http land, but I
think TLS should probably (also?) deal with this somehow.

Thoughts?

[bradfitz]

Comment 1:

Failing test in http://golang.org/cl/5092045/

[bradfitz]

Comment 2:

rsc writes:
> If tls is ignoring _any_ read error,
> including EAGAIN, that's a bug and
> should be fixed.
What's happening is that err,(net.Error).Temporary() == true, so it retries.

[rsc]

Comment 3:

I don't remember why that's there.  It doesn't seem right.

[bradfitz]

Comment 4:

Submitted the failing (but disabled) test in
http://code.google.com/p/go/source/detail?r=6cf7829b4c9287fb7a5713622a1af4546d567c63
The fix for this bug should enable that test.

[agl]

Comment 5:

This issue was closed by revision 9d99d52.

Status changed to Fixed.