Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: upgrade openbsd builders to 6.2 #22835

Closed
4a6f656c opened this issue Nov 21, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@4a6f656c
Copy link
Contributor

commented Nov 21, 2017

OpenBSD 6.2 was released on Oct 9, 2017, meaning that OpenBSD 6.0 is no longer supported. As such, the OpenBSD builders should be updated to run 6.2. It is also worth noting that there are two issues that still need to be addressed to make Go pass a build/test cycle on OpenBSD 6.2 (related to the switch to clang).

@gopherbot

This comment has been minimized.

Copy link

commented Nov 21, 2017

Change https://golang.org/cl/79055 mentions this issue: env: update openbsd builders script to 6.2

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 21, 2017

If the OpenBSD 6.2 build doesn't pass yet, we shouldn't remove the OpenbSD 6.0 builders yet.

We should probably run both for a bit.

Are there issues filed for the two issues you mentioned?

@bradfitz bradfitz changed the title builders: upgrade openbsd builders to 6.2 x/build: upgrade openbsd builders to 6.2 Nov 21, 2017

@gopherbot gopherbot added this to the Unreleased milestone Nov 21, 2017

@gopherbot gopherbot added the Builders label Nov 21, 2017

@bradfitz bradfitz added OS-OpenBSD and removed Builders labels Nov 21, 2017

@gopherbot gopherbot added the Builders label Nov 21, 2017

gopherbot pushed a commit to golang/build that referenced this issue Nov 24, 2017

env: update openbsd builders script to 6.2
Update issue golang/go#22835

Change-Id: Ie9e10625f99957f7bc828c5cacb11f24be16e466
Reviewed-on: https://go-review.googlesource.com/79055
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Nov 24, 2017

Change https://golang.org/cl/79835 mentions this issue: dashboard: add openbsd-amd64-62 (OpenBSD 6.2) builder

gopherbot pushed a commit to golang/build that referenced this issue Nov 24, 2017

dashboard: add openbsd-amd64-62 (OpenBSD 6.2) builder
386 isn't ready yet.

Updates golang/go#22835

Change-Id: Id452140492c0bc5ee850703e640abcbd41e75f9c
Reviewed-on: https://go-review.googlesource.com/79835
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 5, 2017

@4a6f656c, can you help with the openbsd/386 6.2 builder images?

The openbsd/amd64 6.2 make.bash worked fine, but 386 ends with:

Select sets by entering a set name, a file name pattern or 'all'. De-select
sets by prepending a '-', e.g.: '-game*'. Selected sets are labelled '[X]'.
    [X] bsd           [X] base62.tgz    [X] game62.tgz    [X] xfont62.tgz
    [X] bsd.mp        [X] comp62.tgz    [X] xbase62.tgz   [X] xserv62.tgz
    [X] bsd.rd        [X] man62.tgz     [X] xshare62.tgz  [ ] site62.tgz
Set name(s)? (or 'abort' or 'done') [done] +* -x* -game* -man* done
Directory does not contain SHA256.sig. Continue without verification? [no] yes
Installing bsd          100% |**************************| 11982 KB    00:09
Installing bsd.mp       100% |**************************| 12065 KB    00:10
Installing bsd.rd       100% |**************************|  8696 KB    00:07
Installing base62.tgz   100% |**************************|   138 MB    03:02
Extracting etc.tgz      100% |**************************|   189 KB    00:00
Installing comp62.tgz   100% |**************************| 71787 KB    01:46
Installing site62.tgz   100% |**************************|   560       00:00
Location of sets? (cd0 disk http or 'done') [done] done
Saving configuration files...done.
Making all device nodes...done.
Multiprocessor machine; using bsd.mp instead of bsd.
Relinking to create unique kernel...done.

But no output file:

bradfitz@gdev:~/src/golang.org/x/build/env/openbsd-386$ ls -l
total 549012
-rw-r--r-- 1 bradfitz bradfitz 226304000 Dec 10  2016 install60-i386.iso
-rw-r--r-- 1 bradfitz bradfitz 335865856 Nov 24 04:27 install62-i386.iso
-rwxr-xr-x 1 bradfitz bradfitz       221 Jan 24  2016 make.bash
-rw-r--r-- 1 bradfitz bradfitz        29 Jan 24  2016 README
@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 5, 2017

And sometimes it times out before the "Relinking" line. With set -x in the bash script:

...
Directory does not contain SHA256.sig. Continue without verification? [no] yes
Installing bsd          100% |**************************| 11982 KB    00:10
Installing bsd.mp       100% |**************************| 12065 KB    00:10
Installing bsd.rd       100% |**************************|  8696 KB    00:08
Installing base62.tgz   100% |**************************|   138 MB    03:18
Extracting etc.tgz      100% |**************************|   189 KB    00:00
Installing comp62.tgz   100% |**************************| 71787 KB    01:57
Installing site62.tgz   100% |**************************|   559       00:00
Location of sets? (cd0 disk http or 'done') [done] done
Saving configuration files...done.
Making all device nodes...done.
Multiprocessor machine; using bsd.mp instead of bsd.
+ cleanup
+ rm -f install62-i386-patched.iso
+ rm -f auto_install.conf
+ rm -f boot.conf
+ rm -f disk.raw
+ rm -f disklabel.template
+ rm -f etc/rc.local
+ rm -f install.site
+ rm -f random.seed
+ rm -f site62.tgz
+ rmdir etc
bradfitz@gdev:~/src/golang.org/x/build/env/openbsd-386$
bradfitz@gdev:~/src/golang.org/x/build/env/openbsd-386$ echo $?
1
@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 5, 2017

And sometimes it times out before ....

... and that made me realize it was probably just CPU-bound. I doubled the timeout and it's good now.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 5, 2017

Change https://golang.org/cl/81875 mentions this issue: env/openbsd, dashboard: add OpenBSD 6.2 386 builder

@golang golang locked and limited conversation to collaborators Dec 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.