x/net/http2: stderr spam from running tests #22850
Closed
Labels
Milestone
Comments
@bradfitz its enough to just add |
@gregory-m, that's too big of a hammer. I'd prefer to do it per-test, and understand per-test whether we want no logging, or want something specific logged. We do that elsewhere already (maybe in net/http, if not x/net/http2) |
Ok, I will create CL. |
Change https://golang.org/cl/80235 mentions this issue: |
c3mb0
pushed a commit
to c3mb0/net
that referenced
this issue
Apr 2, 2018
In invalid response tests logger write error messages to stderr and spam test output. Since we know response are invalid in these tests we can safely discard logger output. Fixes golang/go#22850 Change-Id: Id8c97be910f0cf7dbe2380ba632960364bc8478b Reviewed-on: https://go-review.googlesource.com/80235 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Tests shouldn't spam to stderr:
From:
/cc @tombergan
The text was updated successfully, but these errors were encountered: