Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestLookupLongTXT failing #22857

Open
0intro opened this issue Nov 23, 2017 · 9 comments
Open

net: TestLookupLongTXT failing #22857

0intro opened this issue Nov 23, 2017 · 9 comments

Comments

@0intro
Copy link
Member

@0intro 0intro commented Nov 23, 2017

CL 79555 added TestLookupLongTXT. This test is failing on Plan 9.

--- FAIL: TestLookupLongTXT (0.05s)
	lookup_test.go:323: LookupTXT golang.rsc.io incorrect
		have ["abcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXY"]
		want ["abcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXY" "gophers rule"]
FAIL
FAIL	net	23.605s

See https://build.golang.org/log/d83b9b31e94b0b5093c0d2813f78105531e8de3e

@0intro 0intro added the OS-Plan9 label Nov 23, 2017
@0intro 0intro added this to the Go1.10 milestone Nov 23, 2017
@0intro 0intro self-assigned this Nov 23, 2017
@0intro
Copy link
Member Author

@0intro 0intro commented Nov 23, 2017

It seems the Plan 9 DNS resolver (ndb/dns) only returns a single TXT record. It probably should be fixed.

cpu% ndb/dnsquery
> rsc.io ip
rsc.io ip	216.239.38.21
rsc.io ip	216.239.34.21
rsc.io ip	216.239.32.21
rsc.io ip	216.239.36.21
> golang.rsc.io txt
golang.rsc.io txt	gophers rule
> gandi.net txt
gandi.net txt	google-site-verification: OyQ-vUKOBlZ2onEvCpyG7UGmQC1_tahPOUSNqCWYruo
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 23, 2017

Change https://golang.org/cl/79695 mentions this issue: net: skip TestLookupLongTXT on Plan 9

gopherbot pushed a commit that referenced this issue Nov 23, 2017
CL 79555 added TestLookupLongTXT. However, this test is
failing on Plan 9, because the DNS resolver (ndb/dns)
only returns a single TXT record.

Updates #22857.

Change-Id: I33cdc63a3d3de4d1c7f2684934316c44992fb9e2
Reviewed-on: https://go-review.googlesource.com/79695
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz bradfitz modified the milestones: Go1.10, Unplanned Nov 28, 2017
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 28, 2017

@0intro, feel free to send plan9 fixes whenever, but I'm removing this from Go1.10. If the fix only touches plan9 stuff, I'm comfortable taking it even late in the cycle.

@mvdan
Copy link
Member

@mvdan mvdan commented Jan 16, 2018

Different, potentially related failure: https://storage.googleapis.com/go-build-log/d38832a2/linux-amd64_b2d10b95.log

--- FAIL: TestLookupLongTXT (1.14s)
	lookup_test.go:342: LookupTXT golang.rsc.io incorrect
		have ["gophers rule"]
		want ["abcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXYabcdefghijklmnopqrstuvwxyABCDEFGHJIKLMNOPQRSTUVWXY" "gophers rule"]

This happened on an unrelated CL, https://go-review.googlesource.com/c/go/+/77253 - linux-amd64 at d38832a2029f83e62a9ddfccfff6c2fc4e3a393e.

@bradfitz bradfitz changed the title net: TestLookupLongTXT failing on Plan 9 net: TestLookupLongTXT failing Feb 27, 2018
@bradfitz bradfitz added NeedsFix and removed OS-Plan9 labels Feb 27, 2018
@bradfitz bradfitz modified the milestones: Unplanned, Go1.11 Feb 27, 2018
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 27, 2018

This isn't just a plan9 issue. It's failing all over the place.

@ianlancetaylor and @rsc were discussing the problem recently. I think they understand what's happening here. Ian, can you summarize?

/cc @mikioh

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 27, 2018

Change https://golang.org/cl/97416 mentions this issue: net: skip flaky TestLookupLongTXT for now

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Feb 27, 2018

I don't actually understand what is going on here. Maybe @rsc does. It seems to have something to do with how caches handle multiple TXT records.

gopherbot pushed a commit that referenced this issue Mar 2, 2018
Flaky tests failing trybots help nobody.

Updates #22857

Change-Id: I87bc018651ab4fe02560a6d24c08a1d7ccd8ba37
Reviewed-on: https://go-review.googlesource.com/97416
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 27, 2018
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 18, 2018

This code was rewritten as part of #21160. We should try enabling the test again at the start of the 1.13 cycle.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 18, 2018

See also #23873.

@bradfitz bradfitz modified the milestones: Go1.13, Go1.14 Apr 29, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.