Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: document more that Get/Post/RoundTrip response is streaming #22873

Closed
bradfitz opened this issue Nov 25, 2017 · 1 comment
Closed

net/http: document more that Get/Post/RoundTrip response is streaming #22873

bradfitz opened this issue Nov 25, 2017 · 1 comment
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 25, 2017

Document on the http.Response type at least that Responses in Go are streaming, and the Response just represents the response headers, but the Body may not have arrived yet, and may fail while it's read.

If we put this on the Response type, we don't need to duplicate it in a dozen places.

(Suggestion by @fanirthuban in #22235 (comment))

@bradfitz bradfitz added this to the Go1.10 milestone Nov 25, 2017
@bradfitz bradfitz self-assigned this Nov 25, 2017
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 27, 2017

Change https://golang.org/cl/80075 mentions this issue: net/http: document streaming nature of Response.Body

@gopherbot gopherbot closed this in d3c1df7 Nov 28, 2017
@golang golang locked and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.