Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: exit compilation earlier if type checking fails #22909

Closed
mdempsky opened this issue Nov 28, 2017 · 2 comments
Closed

cmd/compile: exit compilation earlier if type checking fails #22909

mdempsky opened this issue Nov 28, 2017 · 2 comments

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Nov 28, 2017

Issues like #22904 happen because the backend doesn't expect to deal with invalid code. Instead of having to kludge checks everywhere, we should just exit compilation at the end of type checking if we found any errors. (Analogously, we already exit after parsing if there are syntax errors.)

/cc @griesemer

@griesemer

This comment has been minimized.

Copy link
Contributor

@griesemer griesemer commented Jun 5, 2018

This should be easy to do and increase compiler stability. Marking release blocker.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jun 5, 2018

Change https://golang.org/cl/116335 mentions this issue: cmd/compile: terminate compilation if type-checking fails

@gopherbot gopherbot closed this in d159d61 Jun 6, 2018
@golang golang locked and limited conversation to collaborators Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.