Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: automate GOROOT_BOOTSTRAP tarball creation #22912

Closed
bradfitz opened this issue Nov 28, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Nov 28, 2017

Most of the builder images store their GOROOT_BOOTSTRAP contents in a tarball on GCS.

That tarball is built by hand, starting with bootstrap.bash and then trimmed down (e.g. #9797 (comment))

Let's automate this. It's getting painful.

@bradfitz bradfitz self-assigned this Nov 28, 2017

@gopherbot gopherbot added this to the Unreleased milestone Nov 28, 2017

@gopherbot gopherbot added the Builders label Nov 28, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Nov 30, 2017

Change https://golang.org/cl/80895 mentions this issue: build: add alternate output format for bootstrap.bash, as used by builders

@gopherbot gopherbot closed this in f0f62fc Nov 30, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Jan 30, 2018

Change https://golang.org/cl/90715 mentions this issue: bootstrap.bash: only fetch git revision if we need it

gopherbot pushed a commit that referenced this issue Jan 30, 2018

bootstrap.bash: only fetch git revision if we need it
Updates #22912
Fixes #23610

Change-Id: Id1c91fc3f040412d5931dba40e430685793f8eea
Reviewed-on: https://go-review.googlesource.com/90715
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@golang golang locked and limited conversation to collaborators Jan 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.