Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: improve arm64 memmove #22925

Closed
mrosier-qdt opened this issue Nov 29, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@mrosier-qdt
Copy link
Contributor

commented Nov 29, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.9.2 linux/arm64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

What did you do?

Identified via inspection.

What did you expect to see?

The implementation can be improved by unrolling loops and using sets of ldp and stp instructions.

What did you see instead?

@bradfitz bradfitz changed the title runtime/memmove: improve arm64 target-specific implementation runtime: improve arm64 memmove Nov 29, 2017

@bradfitz bradfitz added this to the Unplanned milestone Nov 29, 2017

@mrosier-qdt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2017

The intent of this bug report is to convey the fact that my team and I are developing an improved version of the memmove routine for arm64. This is based on results from https://blog.cloudflare.com/arm-takes-wing/

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

The tree opens for performance work in early February. Please have code review(s) w/ benchstat performance numbers in the commits ready by then. The tree will close for performance work in early May.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

@mrosier-qdt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 29, 2017

Will do. Thanks, Brad.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 13, 2017

Change https://golang.org/cl/83799 mentions this issue: runtime: improve arm64 memmove implementation.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 16, 2017

Change https://golang.org/cl/83175 mentions this issue: runtime: improve arm64 memmove

@gopherbot gopherbot closed this in 213a751 Mar 1, 2018

@golang golang locked and limited conversation to collaborators Mar 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.