Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: unsafe pointer maps #22931

Open
RLH opened this issue Nov 29, 2017 · 3 comments
Open

runtime: unsafe pointer maps #22931

RLH opened this issue Nov 29, 2017 · 3 comments
Assignees
Milestone

Comments

@RLH
Copy link
Contributor

@RLH RLH commented Nov 29, 2017

There are several places in the code where pointers are stored into slots that the pointer maps do not note as holding pointers.

While the occurrences found so far appear benign with the current GC they do prevent adding diagnostics to the write barrier intended to detect errant writes. At the very least they should be documented as to why they are benign.

@robpike
Copy link
Contributor

@robpike robpike commented Nov 30, 2017

It would be nice to list those locations here.

@RLH
Copy link
Contributor Author

@RLH RLH commented Nov 30, 2017

@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone Mar 29, 2018
@ianlancetaylor ianlancetaylor removed this from the Go1.11 milestone Jul 10, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Jul 10, 2018
@odeke-em
Copy link
Member

@odeke-em odeke-em commented Feb 4, 2019

Great, thank you @RLH for the report and for the initial CL to get things rolling!

I am going to also kindly page @josharian @randall77 @mknyszek @aclements who might
all be interested in this issue and then punt this issue to Go1.13.

@odeke-em odeke-em removed this from the Go1.12 milestone Feb 4, 2019
@odeke-em odeke-em added this to the Go1.13 milestone Feb 4, 2019
@andybons andybons removed this from the Go1.13 milestone Jul 8, 2019
@andybons andybons added this to the Go1.14 milestone Jul 8, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants