New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: unsafe pointer maps #22931

Open
RLH opened this Issue Nov 29, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@RLH
Contributor

RLH commented Nov 29, 2017

There are several places in the code where pointers are stored into slots that the pointer maps do not note as holding pointers.

While the occurrences found so far appear benign with the current GC they do prevent adding diagnostics to the write barrier intended to detect errant writes. At the very least they should be documented as to why they are benign.

@robpike

This comment has been minimized.

Contributor

robpike commented Nov 30, 2017

It would be nice to list those locations here.

@RLH

This comment has been minimized.

Contributor

RLH commented Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment