Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: signal stack change broke DragonflyBSD #23061

Closed
bradfitz opened this issue Dec 8, 2017 · 4 comments
Closed

runtime: signal stack change broke DragonflyBSD #23061

bradfitz opened this issue Dec 8, 2017 · 4 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 8, 2017

This CL (292558b) broke Dragonfly:

runtime: restore the Go-allocated signal stack in unminit
https://go-review.googlesource.com/c/go/+/81476

I emailed Austin & Ian details of how to access a VM I created.

@bradfitz bradfitz added this to the Go1.10 milestone Dec 8, 2017
@bradfitz

This comment has been minimized.

Copy link
Contributor Author

@bradfitz bradfitz commented Dec 8, 2017

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 8, 2017

This most likely has to do with the fact that on DragonFly a newly created thread inherits the alternate signal stack of the creating thread. See the comment in minit in runtime/os_dragonfly.go.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 8, 2017

Sorry, I was looking at an old source tree due to a complex accident. DragonFly used to work that way, but it's been fixed.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Dec 9, 2017

Change https://golang.org/cl/83035 mentions this issue: runtime: don't use MAP_STACK on DragonFly in SigStack test

@gopherbot gopherbot closed this in 29cb57c Dec 9, 2017
@golang golang locked and limited conversation to collaborators Dec 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.