Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: UDPConn.WriteMsgUDP fails on Windows XP #23072

Closed
alexbrainman opened this issue Dec 9, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@alexbrainman
Copy link
Member

commented Dec 9, 2017

new windows-386-xp builder on https://build.golang.org fails at commit 29cb57c

https://build.golang.org/log/e18744bedc520329ee61476194bf5020a66ba706

with

--- FAIL: TestUDPConnSpecificMethods (0.02s)
	protoconn_test.go:142: write udp4 127.0.0.1:1138->127.0.0.1:1138: wsasendmsg: An invalid argument was supplied.
--- FAIL: TestWriteToUDP (0.00s)
	udpsock_test.go:168: write udp 127.0.0.1:1282: wsasendmsg: An invalid argument was supplied.
FAIL
FAIL	net	10.336s

As I explained at #10267 (comment) I think we should just skip correspondent parts of the test on Windows XP.

Alex

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 9, 2017

What's the proper way to detect XP?

@bradfitz bradfitz added this to the Go1.10 milestone Dec 9, 2017

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2017

What's the proper way to detect XP?

Search for isWindowsXP in main repo.

I am going to send a fix for this in a little while. Please wait.

Alex

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2017

@bradfitz do we have Windows XP trybot?

Alex

@gopherbot

This comment has been minimized.

Copy link

commented Dec 10, 2017

Change https://golang.org/cl/83076 mentions this issue: internal/testenv: introduce IsWindowsXP

@gopherbot

This comment has been minimized.

Copy link

commented Dec 10, 2017

Change https://golang.org/cl/83077 mentions this issue: net: skip some tests on Windows XP

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 10, 2017

@alexbrainman, no trybot. We just have a single XP VM currently. Maybe @johnsonj will get Windows Server 2003 working on GCE and then we could have an opt-in Trybot or something.

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2017

Cool, I will test my change here, and then we'll submit and see.

Alex

@alexbrainman

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2017

I really do not know how to fix this - I am not even sure if it is possible to fix. I am just skipping broken tests for the moment.

Alex

@bradfitz

This comment has been minimized.

Copy link
Member

commented Dec 10, 2017

@alexbrainman, that's fine.

gopherbot pushed a commit that referenced this issue Dec 10, 2017

internal/testenv: introduce IsWindowsXP
For #23072

Change-Id: I089feafef2900413d46f2358b6e41ab78187eced
Reviewed-on: https://go-review.googlesource.com/83076
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

gopherbot pushed a commit that referenced this issue Dec 10, 2017

net: skip some tests on Windows XP
Parts of TestUDPConnSpecificMethods and TestWriteToUDP fail, because
UDPConn.WriteMsgUDP is broken on Windows XP. UDPConn.WriteMsgUDP uses
Windows WSASendMsg API, but that call is not implemented on Windows XP (see
https://msdn.microsoft.com/en-us/library/windows/desktop/ms741692(v=vs.85).aspx
for details)

Update #23072

Change-Id: I4e8f149bc62bd87cd7c199e6832b9ce479af0a3e
Reviewed-on: https://go-review.googlesource.com/83077
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@bradfitz bradfitz modified the milestones: Go1.10, Unplanned Dec 10, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Feb 15, 2018

Change https://golang.org/cl/94255 mentions this issue: all: drop support for Windows Vista or below

@gopherbot gopherbot closed this in d50bb8d Feb 15, 2018

@golang golang locked and limited conversation to collaborators Feb 15, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.