New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go, cmd/link: support buildmode=shared on darwin #23126

Open
hirochachacha opened this Issue Dec 13, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@hirochachacha
Contributor

hirochachacha commented Dec 13, 2017

I'd like to support buildmode=shared on darwin in the Go1.11 dev cycle.
I did some attempt before. https://go-review.googlesource.com/c/go/+/57750.
So it should be easy for me to prepare subsequent CLs for Go1.11.

@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Mar 29, 2018

@akavel

This comment has been minimized.

Contributor

akavel commented Apr 25, 2018

@hirochachacha do you maybe have some updates on this? I'm interested in trying to start working on buildmode=shared on Windows, and I'd love to build on your work, it'd make my part so much easier...

Regardless of your progress, I'd like to ask if the CL 57750 is in a good working state? Do you think it would make sense for me to fork it and start adding a first prototype attempt for Windows support onto it? Or does it have some important missing parts? I don't care if it's not pretty or "merge-ready", as I'm gonna be doing dirty hacking myself for the first prototype anyway. All I'm interested in is to what extent it's a working proof of concept for you already, or not yet? Thanks!

@hirochachacha

This comment has been minimized.

Contributor

hirochachacha commented Apr 30, 2018

@hirochachacha do you maybe have some updates on this? I'm interested in trying to start working on buildmode=shared on Windows, and I'd love to build on your work, it'd make my part so much easier...

@akavel Sorry for the late reply. I don't have any updates about this because I was busy and couldn't get motivated. However, I have long weekend in this week, so I'd tackle this again. Thank you for reminding me and motivating me! So I will rebase and split this. If you want to make your own CL on top of this, and you didn't start yet, you may want to wait some time.

Regardless of your progress, I'd like to ask if the CL 57750 is in a good working state? Do you think it would make sense for me to fork it and start adding a first prototype attempt for Windows support onto it? Or does it have some important missing parts? I don't care if it's not pretty or "merge-ready", as I'm gonna be doing dirty hacking myself for the first prototype anyway. All I'm interested in is to what extent it's a working proof of concept for you already, or not yet? Thanks!

IIRC, it worked as expected. But I didn't test massively. Maybe I was missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment