Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/perf/cmd/benchstat: documentation missing information about -alpha option #23138

Closed
laboger opened this issue Dec 14, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@laboger
Copy link
Contributor

commented Dec 14, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go1.10beta1

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

ppc64le Ubuntu

What did you do?

Tried to use benchstat for comparing benchmark results. Thought something was wrong on ppc64le because the delta column was always ~ even though I could see significant differences in the results columns.

Tried to use benchstat -h and found -alpha which I assumed is that I needed:

 -alpha a
    	consider change significant if p < a (default 0.001)

From this it was not clear what p is, so I went here:

https://godoc.org/golang.org/x/perf/cmd/benchstat
but this documentation doesn't even mention alpha.

So after trial and error I found an alpha value that would give me what I want.

@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2017

@bradfitz bradfitz changed the title x/perf/cmd/benchstat: documention missing information about -alpha option x/perf/cmd/benchstat: documentation missing information about -alpha option Dec 15, 2017

@ALTree

This comment has been minimized.

Copy link
Member

commented Dec 15, 2017

dup of #20727

@mvdan

This comment has been minimized.

Copy link
Member

commented Dec 15, 2017

Sure seems like it.

@mvdan mvdan closed this Dec 15, 2017

@golang golang locked and limited conversation to collaborators Dec 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.