New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/ssa/interp: tests consistently failing on darwin #23166

Open
mvdan opened this Issue Dec 18, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@mvdan
Member

mvdan commented Dec 18, 2017

Spotted on a recent x/tools CL: https://storage.googleapis.com/go-build-log/2de98eb8/darwin-amd64-10_11_1d3b7b4f.log

[...]
Input: static.go
PASS
Input: callstack.go
panic: runtime error: invalid memory address or nil pointer dereference
FAIL
To trace execution, run:
% go build golang.org/x/tools/cmd/ssadump && ./ssadump -build=C -test -run --interp=T callstack.go

The following tests failed:
	boundmeth.go
	complit.go
	coverage.go
	defer.go
	initorder.go
	range.go
	recover.go
	callstack.go
--- FAIL: TestTestdataFiles (23.62s)
	interp_test.go:231: interp.Interpret([testdata/boundmeth.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/complit.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/coverage.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/defer.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/initorder.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/range.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/recover.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/callstack.go]) failed: exit code was 2
FAIL
FAIL	golang.org/x/tools/go/ssa/interp	24.378s

The build dashboard shows that this has been happening since December 10th: https://build.golang.org/?repo=golang.org%2fx%2ftools

It's not immediately obvious if it was a change in this repo or a change in Go that introduced this. Or if something is up with the machines.

/cc @alandonovan @bradfitz

@bradfitz

This comment has been minimized.

Member

bradfitz commented Dec 18, 2017

@alandonovan, please fix soon for Go 1.10.

These tests are super fragile.

@alandonovan

This comment has been minimized.

Contributor

alandonovan commented Dec 18, 2017

@bradfitz

This comment has been minimized.

Member

bradfitz commented Dec 18, 2017

gomote works for Macs, FWIW.

@bradfitz

This comment has been minimized.

Member

bradfitz commented Jan 3, 2018

This continuing to fail is interfering with development of unrelated packages in x/tools.

@mvdan

This comment has been minimized.

Member

mvdan commented Jan 3, 2018

@bradfitz perhaps those tests could be temporarily disabled on Mac until Alan has time to have a look?

@bradfitz

This comment has been minimized.

Member

bradfitz commented Jan 3, 2018

@mvdan, yup, on it.

@gopherbot

This comment has been minimized.

gopherbot commented Jan 3, 2018

Change https://golang.org/cl/85995 mentions this issue: go/ssa/interp: skip tests on darwin until crashes are fixed

gopherbot pushed a commit to golang/tools that referenced this issue Jan 3, 2018

go/ssa/interp: skip tests on darwin until crashes are fixed
Updates golang/go#23166

Change-Id: Ie9db70d6f2f8d90817ec3de35e6ca51ec476f949
Reviewed-on: https://go-review.googlesource.com/85995
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@ianlancetaylor

This comment has been minimized.

Contributor

ianlancetaylor commented Jan 24, 2018

It looks we are skipping the tests for now, so this is presumably not a release blocker for 1.10. Shifting to 1.11.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Go1.11 Jan 24, 2018

@griesemer

This comment has been minimized.

Contributor

griesemer commented Jun 27, 2018

Again; not a release-blocker for 1.11.

@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 27, 2018

@mvdan mvdan modified the milestones: Go1.12, Go1.13 Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment