Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upruntime: -l=4 build fails on Solaris #23168
Comments
|
The main thing those three tests have is that they compile a small Go program with "regular" optimization (as opposed to building with "-l -N"), in case that helps. |
|
Change https://golang.org/cl/84655 mentions this issue: |
Disable the three linker DWARF tests that invoke the compiler in non-debug mode on Solaris, since this seems to trigger a split stack overflow. These can be turned back on once the issue in question is resolved. Updates #23168. Change-Id: I5be1b098e33e8bad3bc234a0964eab1dee7e7954 Reviewed-on: https://go-review.googlesource.com/84655 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Than McIntosh <thanm@google.com>
|
This is essentially the same problem we had in #22797. Building the runtime with I'll re-title this issue and milestone it to 1.11. |
aclements
changed the title
|
Change https://golang.org/cl/111258 mentions this issue: |
A few libc_ calls were missing stack switches.
Unfortunately, adding the stack switches revealed a deeper problem.
systemstack() is fundamentally flawed because when you do
systemstack(func() { ... })
There's no way to mark the anonymous function as nosplit. At first I
thought it didn't matter, as that function runs on the g0 stack. But
nosplit is still required, because some syscalls are done when stack
bounds are not set up correctly (e.g. in a signal handler, which runs
on the g0 stack, but g is still pointing at the g stack). Instead use
asmcgocall and funcPC, so we can be nosplit all the way down.
Mid-stack inlining now pushes darwin over the nosplit limit also.
Leaving that as a TODO.
Update #23168
This might fix the cause of occasional darwin hangs.
Update #25181
Update #17490
Change-Id: If9c3ef052822c7679f5a1dd192443f714483327e
Reviewed-on: https://go-review.googlesource.com/111258
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Starting with @thanm's https://go-review.googlesource.com/c/go/+/83675, the
cmd/link/internal/ldtests are failing on Solaris with:https://build.golang.org/log/c7bc05a2441135a63ae2929882eeb166e17f9df8
/cc @aclements