Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: TLS interface only supports RSA keys #2319

Closed
gopherbot opened this issue Sep 29, 2011 · 5 comments
Closed

crypto/tls: TLS interface only supports RSA keys #2319

gopherbot opened this issue Sep 29, 2011 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 29, 2011

by louisk@google.com:

As a public interface, the crypto.tls.Certificate type, currently defined as:
type Certificate struct {
    Certificate [][]byte
    PrivateKey  *rsa.PrivateKey
    ...
}

probably should have the PrivateKey field changed to an interface type.  Otherwise it
would be very difficult to add implementations for non-RSA cipher suites in the future.
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 29, 2011

Comment 1:

-> agl for triage

Owner changed to @agl.

@agl

This comment has been minimized.

Copy link
Contributor

@agl agl commented Sep 29, 2011

Comment 2:

I'd be happy to see ECDSA support in the future (or even ECDH). But that field can be
made into an interface{} once we have more than one key type supported. It's unlike to
break anything when we do that.

Status changed to HelpWanted.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Oct 6, 2011

Comment 3:

Status changed to LongTerm.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Dec 9, 2011

Comment 4:

Labels changed: added priority-later.

@agl

This comment has been minimized.

Copy link
Contributor

@agl agl commented Dec 19, 2011

Comment 5:

This issue was closed by revision 2ca4a61.

Status changed to Fixed.

@mikioh mikioh changed the title TLS interface only supports RSA keys crypto/tls: TLS interface only supports RSA keys Jan 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
We still very much assume it in the code, but with this change in
place we can implement other things later without changing and users
of the package.

Fixes golang#2319.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5489073
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.