Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: typo in error message in ssh/certs.go #23266

Closed
parsiya opened this issue Dec 28, 2017 · 1 comment
Closed

x/crypto/ssh: typo in error message in ssh/certs.go #23266

parsiya opened this issue Dec 28, 2017 · 1 comment
Milestone

Comments

@parsiya
Copy link

@parsiya parsiya commented Dec 28, 2017

The error message in CheckCert function in ssh/certs.go#L343 has a typo.

When an SSH certificate is revoked (IsRevoked callback in CertCheck is set and returns true), the following error message is returned:

return fmt.Errorf("ssh: certicate serial %d revoked", cert.Serial)

certicate should be certificate.

@gopherbot gopherbot added this to the Unreleased milestone Dec 28, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 28, 2017

Change https://golang.org/cl/85595 mentions this issue: crypto/ssh: fix typo in error message in certs.go

@odeke-em odeke-em changed the title x/crypto/ssh typo in error message in ssh/certs.go x/crypto/ssh: typo in error message in ssh/certs.go Dec 28, 2017
@golang golang locked and limited conversation to collaborators Dec 28, 2018
bored-engineer pushed a commit to bored-engineer/ssh that referenced this issue Oct 13, 2019
Fixes golang/go#23266

Change-Id: I8da14425ed69c44a7b0c56b1aa0ea951fe297608
Reviewed-on: https://go-review.googlesource.com/85595
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
bored-engineer pushed a commit to bored-engineer/ssh that referenced this issue Oct 13, 2019
Fixes golang/go#23266

Change-Id: I8da14425ed69c44a7b0c56b1aa0ea951fe297608
Reviewed-on: https://go-review.googlesource.com/85595
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.