Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: use NEGL for DIVL #23310

Closed
mdempsky opened this issue Jan 2, 2018 · 1 comment
Closed

cmd/compile: use NEGL for DIVL #23310

mdempsky opened this issue Jan 2, 2018 · 1 comment
Milestone

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Jan 2, 2018

When emitting the code to handle x / -1 on amd64, we should use the size-appropriate negation operation. For example, NEGL for DIVL.

This probably also means using NEGW for DIVW, which might also apply to the 386 backend?

Fixing this should allow reverting https://go-review.googlesource.com/c/go/+/85736. See also #23305.

/cc @TocarIP @cherrymui

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Feb 23, 2018

Change https://golang.org/cl/96815 mentions this issue: cmd/compile/internal/amd64: use appropriate NEG for div

@gopherbot gopherbot closed this in f4d9c30 Feb 26, 2018
@golang golang locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.