Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: move to exp/html #2341

Closed
rsc opened this issue Oct 6, 2011 · 13 comments
Closed

html: move to exp/html #2341

rsc opened this issue Oct 6, 2011 · 13 comments
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Oct 6, 2011

Using this as a meta-tracking bug.  See the bugs merged into this one for details.
It should really be in exp/html.  If it's not going to be ready for Go 1 then
we should move it there.
@rsc
Copy link
Contributor Author

@rsc rsc commented Oct 6, 2011

Comment 1:

Issue #2229 has been merged into this issue.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Oct 6, 2011

Comment 2:

Issue #1889 has been merged into this issue.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Oct 6, 2011

Comment 3:

Issue #1751 has been merged into this issue.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Oct 6, 2011

Comment 4:

Issue #1661 has been merged into this issue.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Dec 9, 2011

Comment 5:

Labels changed: added priority-later, removed priority-medium.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Dec 12, 2011

Comment 6:

Labels changed: added priority-go1.

Loading

@robpike
Copy link
Contributor

@robpike robpike commented Jan 13, 2012

Comment 7:

Owner changed to builder@golang.org.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Jan 24, 2012

Comment 8:

It's time to stop working on new code.  Is package html done?
If so, great.  If not, let's move to exp/html and maybe it can be
in Go 1.1.  Thanks.

Owner changed to @nigeltao.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 24, 2012

Comment 9 by nigel.tao.gnome:

It's not done, in that it's not fully conformant with HTML5. But I don't expect any API
changes between now and getting 100% of the test cases passing. It already handles
trickiness like <svg> and <math>. But there might be some dark corner of
HTML5 which isn't explored yet.
I guess that that means that package html should move to exp/html.
Is html/template unaffected? It currently depends on exp/html for a small utility
function (html.UnescapeString), but that's copy/pastable.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Jan 24, 2012

Comment 10:

Do you want people using html in production
and complaining when it fails?  If not, then
it should be in exp/html.
Yes, please copy/paste the utility function.

Loading

@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Jan 24, 2012

Comment 11:

I've got second thoughts on copy/paste. There's non-trivial code [0] and a large look-up
table [1].
[0] http://golang.org/src/pkg/html/escape.go?h=func+unescapeEntity#L57
[1] http://golang.org/src/pkg/html/entity.go?h=var+entity#L16
How about keeping html.EscapeString and htmlUnescapeString, but moving all the
tokenization and parsing code to exp/html?
The other option is moving html/template to exp/html/template.

Loading

@rsc
Copy link
Contributor Author

@rsc rsc commented Jan 24, 2012

Comment 12:

html/template needs to stay; it is done and very useful.
It seems fine to leave behind an html package with just EscapeString.
Russ

Loading

@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Jan 25, 2012

Comment 13:

This issue was closed by revision 324513b.

Status changed to Fixed.

Loading

@rsc rsc added fixed labels Jan 25, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants