Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
x/sys: extract Unix includes into separate files #23412
changed the title from
Extract Unix includes into separate files
x/sys: extract Unix includes into separate files
Jan 11, 2018
Sorry, we can't look at patches that are sent as PRs, without CLAs on file. Gerrit enforces CLAs.
Please describe the problem in English and we can decide whether somebody can fix the problem independently.
Or submit it via Gerrit.
Or wait for us to start accepting GitHub PRs, soonish. (with the Google CLA bot)
I have extracted the former into separate files.
@ianlancetaylor I have described this in the firstmost comment of the PR.
I don't quite see a problem with that. FWIW I find it convenient to have the C code inlined in mkerrors.sh as the changes usually consist of adding a header and adjusting the regex in the same file. Splitting them out would mean having to remember to edit one (or even several) more files for each added/changed constant.