Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Go 1.9.3 release status #23475

Closed
andybons opened this issue Jan 18, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@andybons
Copy link
Member

commented Jan 18, 2018

Go 1.9.3 release status

PROBLEMS WITH RELEASE

  • Go1.9.3 milestone has closed issues

ISSUES MISSING FIXES

  • #23392 net/url: Parse accepts invalid userinfo strings
  • #23066 net/http: backport invalid memory address or nil pointer dereference fix?
  • #22976 database/sql: transaction leak
  • #22930 runtime: crash with C sigaltstacks
  • #22842 math/big: r.Exp(x, 1, m) wrong if r is initially non-zero [Go1.9]
  • #22781 runtime: fatal error: sweep increased allocation count, go1.9.x
  • #22725 runtime: reported CPU time of STW phases is low
  • #22683 cmd/compile: 1-sized array's pointer typed element set to nil, after received from channel and print in a loop
  • #22458 cmd/compile: runtime.KeepAlive doesn't work
  • #22429 cmd/compile: invalid instruction error for FMOVD when compiling for 387
  • #21655 cmd/compile: "offset too large" error
  • #20427 runtime: memory corruption crashes with os/exec on Linux kernel 4.4

Issues with fixes

Changes on release branch

Log

2018/01/18 14:46:52 starting
2018/01/18 14:46:52 working in /usr/local/google/home/andybons/go-releasebot-work/go1.9.3
2018/01/18 14:46:52 $ git fetch origin master
2018/01/18 14:46:53 $ git fetch origin release-branch.go1.9
2018/01/18 14:46:54 $ git clone --reference /usr/local/google/home/andybons/go-releasebot-work/go1.9.3/gitmirror -b release-branch.go1.9 https://go.googlesource.com/go /usr/local/google/home/andybons/go-releasebot-work/go1.9.3/gitwork
2018/01/18 14:46:58 $ git codereview change relwork
2018/01/18 14:46:58 $ git config gc.auto 0
2018/01/18 14:46:58 $ git rev-parse go1.9.3
2018/01/18 14:46:59 gerritQuery: HTTP status 400 Bad Request; query is empty
2018/01/18 14:46:59 HTTP status 400 Bad Request; query is empty
2018/01/18 14:46:59 

PANIC: HTTP status 400 Bad Request; query is empty


goroutine 44 [running]:
runtime/debug.Stack(0xc42005d9b0, 0xa679e0, 0xc420ad2050)
	/usr/lib/google-golang/src/runtime/debug/stack.go:24 +0xa7
main.(*Work).recover(0xc420166fc0)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:219 +0x71
panic(0xa679e0, 0xc420ad2050)
	/usr/lib/google-golang/src/runtime/panic.go:491 +0x283
log.(*Logger).Panic(0xc4210ed540, 0xc42005db78, 0x1, 0x1)
	/usr/lib/google-golang/src/log/log.go:212 +0xbe
main.(*Work).gerritQuery(0xc420166fc0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/gerrit.go:34 +0x26a
main.(*Work).queryGerritCLs(0xc420166fc0)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/gerrit.go:47 +0x1a5
main.(*Work).doRelease(0xc420166fc0)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:302 +0x3c8
main.main.func1(0xc420cecbd0, 0xc420166fc0)
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:112 +0x51
created by main.main
	/usr/local/google/home/andybons/gocode/src/golang.org/x/build/cmd/releasebot/main.go:110 +0x4e0

— golang.org/x/build/cmd/releasebot, Jan 18 19:46:59 UTC

@andybons andybons added this to the Go1.9.3 milestone Jan 18, 2018

@andybons andybons closed this Jan 18, 2018

@andybons andybons removed this from the Go1.9.3 milestone Jan 18, 2018

@golang golang locked and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.