Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vendor/golang.org/x/arch/arm64/arm64asm: test zero register mismatch #23478

Closed
prattmic opened this issue Jan 18, 2018 · 2 comments
Closed

cmd/vendor/golang.org/x/arch/arm64/arm64asm: test zero register mismatch #23478

prattmic opened this issue Jan 18, 2018 · 2 comments

Comments

@prattmic
Copy link
Member

@prattmic prattmic commented Jan 18, 2018

I got this when testing near HEAD:

--- FAIL: TestObjdumpARM64Testdata (2.20s)
	ext_test.go:195: decode(744bbf38) = "ldrsb x20, [x27,wzr,uxtw]", 4, want "ldrsb x20, [x27,w31,uxtw]", 4
		
	ext_test.go:195: decode(29493fbc) = "str s9, [x9,wzr,uxtw]", 4, want "str s9, [x9,w31,uxtw]", 4
		
	ext_test.go:195: decode(225bff38) = "ldrsb w2, [x25,wzr,uxtw #0]", 4, want "ldrsb w2, [x25,w31,uxtw #0]", 4
		
	ext_test.go:195: decode(cad8bf78) = "ldrsh x10, [x6,wzr,sxtw #1]", 4, want "ldrsh x10, [x6,w31,sxtw #1]", 4
		
	ext_test.go:195: decode(a278ff3c) = "ldr q2, [x5,xzr,lsl #4]", 4, want "ldr q2, [x5,x31,lsl #4]", 4
		
	ext_test.go:195: decode(a278ff3c) = "ldr q2, [x5,xzr,lsl #4]", 4, want "ldr q2, [x5,x31,lsl #4]", 4
		
	ext_test.go:201: 9203 test cases, 686 expected mismatches, 6 failures; 5781 cases/second
	ext_test.go:202: decoder coverage: 95.5%;
	ext_test.go:201: 9203 test cases, 0 expected mismatches, 0 failures; 17619 cases/second
	ext_test.go:202: decoder coverage: 95.5%;
FAIL
FAIL	cmd/vendor/golang.org/x/arch/arm64/arm64asm	10.074s

From ARMv8 ARM: "In instruction encodings, the value 0b11111 (31) is used to indicate the ZR (zero register)."

So this appears to be a disagreement with objdump about whether to call registers w/xzr or w/x31.

I'm not sure exactly which version of objdump was running on this machine. I can dig around to find it if it would help.

@dmitshur dmitshur changed the title cmd/vendor/golang.org/x/arch/arm64/arm64asm test zero register mismatch cmd/vendor/golang.org/x/arch/arm64/arm64asm: test zero register mismatch Mar 13, 2018
@andybons
Copy link
Member

@andybons andybons commented Mar 13, 2018

@prattmic what revision were you testing at? Were you running all.bash?

Loading

@andybons andybons added this to the Unplanned milestone Mar 26, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 13, 2018

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

Loading

@gopherbot gopherbot closed this Apr 13, 2018
@golang golang locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants