Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: document that StartProcess inherits the caller's thread state #23570

Closed
aclements opened this issue Jan 26, 2018 · 4 comments
Closed

os: document that StartProcess inherits the caller's thread state #23570

aclements opened this issue Jan 26, 2018 · 4 comments

Comments

@aclements
Copy link
Member

@aclements aclements commented Jan 26, 2018

One of the new features of the Go 1.10 runtime is that LockOSThread can be used to reliably modify OS thread state. One of the main points of doing this was to make it possible to start a new process with a modified thread state, but right now we don't document that new processes created with, e.g., os.StartProcess will actually inherit the caller's thread state. This has led to confusion and we should document this.

@aclements aclements added this to the Go1.10 milestone Jan 26, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 26, 2018

Change https://golang.org/cl/90255 mentions this issue: os: document inheritance of thread state over exec

@gopherbot gopherbot closed this in 3ee8c3c Jan 26, 2018
@aclements

This comment has been minimized.

Copy link
Member Author

@aclements aclements commented Jan 26, 2018

Re-opening for cherry-pick to 1.10 release branch.

@aclements aclements reopened this Jan 26, 2018
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jan 26, 2018

At the moment everything checked into the master branch is going to be cherry picked over to the release branch. The master branch is not yet open for general changes. So there is no need to keep this issue open for that purpose.

(That said, you might want to check that the release notes seem clear on this point.)

@aclements

This comment has been minimized.

Copy link
Member Author

@aclements aclements commented Jan 27, 2018

Okay. I'll close the issue.

(That said, you might want to check that the release notes seem clear on this point.)

The exec behavior isn't actually changing; we're just guaranteeing that we'll keep doing what we're doing now. The release notes point to the changes to LockOSThread, which I think is enough (though I could be convinced otherwise).

@aclements aclements closed this Jan 27, 2018
@golang golang locked and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.