/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: detect temp dir leaks #23619

Open
bradfitz opened this Issue Jan 30, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
Builders
Projects
None yet
Milestone
  Unreleased
3 participants
@bradfitz @alexbrainman @gopherbot
@bradfitz
Member

bradfitz commented Jan 30, 2018

The build infrastructure could explicitly set $TMPDIR (or %TMP% on Windows) to an empty directory and at the end of a successful build check that the directory is still empty. If not, it could fail.

Or we could do it in cmd/dist test, perhaps optionally.

/cc @ianlancetaylor @alexbrainman

@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2018

@gopherbot gopherbot added the Builders label Jan 30, 2018

@alexbrainman

This comment has been minimized.

Sign in to view
Member

alexbrainman commented Jan 31, 2018

SGTM

Non Windows users might struggle if they do not know that you cannot delete running executable on Windows, you cannot delete opened file on Windows, you cannot remove directory if it is current directory on Windows and similar.

Alex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment