Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
What version of Go are you using (
Sorry, there's not enough information here. Before evaluating your solution, we need to understand the problem. It's nice that you provided a repo, but it doesn't include information about your environment.
Are you sure you included all the steps? Why is golang.org/x/version.Run even relevant here? I don't see you using the go1.10rc1 binary in your steps above.
The golang.org/x/build/version/... packages have been deprecated in favor of golang.org/dl/... in CL 123678, as part of golang/go#23223. Make this more visible by pointing to the new packages in the package documentation. Use a godoc.org link to avoid confusion, because these import paths are hard tell apart from normal URLs that have a different meaning. Updates golang/go#23635. Updates golang/go#23223. Change-Id: Ide6371f24fa2369b2807987c83df4226cacfe35d Reviewed-on: https://go-review.googlesource.com/c/144617 Reviewed-by: Brad Fitzpatrick <email@example.com>
Package version has been copied from golang.org/x/build/version to golang.org/dl/internal/version as part of golang/go#23223. The old package was marked deprecated but kept for backwards compatibility reasons. Fixes and changes have not been backported from the new dl/internal/version package (to avoid spending time unproductively). bundle has recently been updated to accept an empty prefix in CL 105515. This allows one to use bundle to make a generated copy of a package. A generated copied package is better than a manually-maintained copied package for the following reasons: 1. Keeping the copied package up to date with upstream is low effort, just need to run go generate. 2. It's clear to contributors that the copied package isn't the canonical version, since there is a generated comment like "// Code generated by golang.org/x/tools/cmd/bundle. DO NOT EDIT." at the top of the file. It's easy to reject changes to the copied package, or redirect them to the upstream. Overall, making the copied package generated rather than hand-written reduces the maintenace cost, and makes it more viable to keep it more up to date with upstream. The diff to version.go in this CL is due to some dl/internal/version CLs being effectively backported by bundle, including CL 134435, CL 143545, and CL 144698. Updates golang/go#23223 Fixes golang/go#23635 Change-Id: Id8cd63c52b660b6817e6fdba080373966789e1e8 Reviewed-on: https://go-review.googlesource.com/c/148881 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>