Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: wrong type for DismissedReview.State #23723

Open
broady opened this issue Feb 6, 2018 · 2 comments

Comments

@broady
Copy link
Member

commented Feb 6, 2018

The docs say that it's a string with values commented, approved, changes_requested

https://github.com/golang/build/blob/438dce5f3d2fd35b54f4d5431e53e2029c40fffe/maintner/github.go#L466-L472

https://github.com/golang/build/blob/438dce5f3d2fd35b54f4d5431e53e2029c40fffe/maintner/maintpb/maintner.proto#L144-L151

I can send a change to fix it. I think it'd have no effect on existing code, since if people were using maintner with repos that had GitHub reviews, then they'd already have experienced panics. (I'd add it as a new field and remove the existing one + reserve the proto id)

@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2018

@gopherbot gopherbot added the Builders label Feb 6, 2018

@dmitshur

This comment has been minimized.

Copy link
Member

commented Apr 9, 2018

I think this was mostly resolved in CL 96835.

(Perhaps a followup step can be to check the logs for "got type %T for 'state' field, expected string in %+v" messages and potentially clean up that code path if it's no longer needed.)

This issue can be closed if there's nothing more to do.

@bradfitz bradfitz assigned dmitshur and unassigned bradfitz and broady May 29, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Over to @dmitshur to grep logs on Stackdriver and close this if none found.

FWIW, I see nothing in:

$ k logs maintnerd-deployment-7ddfd868d4-wkf7c | grep "got type" | wc -l
0

But that doesn't go back as far as a Stackdriver log search could.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.