x/build/maintner: wrong type for DismissedReview.State

[broady]

The docs say that it's a string with values commented, approved, changes_requested

https://github.com/golang/build/blob/438dce5f3d2fd35b54f4d5431e53e2029c40fffe/maintner/github.go#L466-L472

https://github.com/golang/build/blob/438dce5f3d2fd35b54f4d5431e53e2029c40fffe/maintner/maintpb/maintner.proto#L144-L151

I can send a change to fix it. I think it'd have no effect on existing code, since if people were using maintner with repos that had GitHub reviews, then they'd already have experienced panics. (I'd add it as a new field and remove the existing one + reserve the proto id)

[dmitshur]

I think this was mostly resolved in CL 96835.

(Perhaps a followup step can be to check the logs for "got type %T for 'state' field, expected string in %+v" messages and potentially clean up that code path if it's no longer needed.)

This issue can be closed if there's nothing more to do.

[bradfitz]

Over to @dmitshur to grep logs on Stackdriver and close this if none found.

FWIW, I see nothing in:

$ k logs maintnerd-deployment-7ddfd868d4-wkf7c | grep "got type" | wc -l
0

But that doesn't go back as far as a Stackdriver log search could.