Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: add 421 status codes into status.go #23776

Closed
ryysud opened this issue Feb 11, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@ryysud
Copy link
Contributor

commented Feb 11, 2018

The following HTTP status codes are registered in the HTTP Status Code Registry, but they are not defined in the net/http package (status.go) .

Is there a reason not to define them?

@gopherbot

This comment has been minimized.

Copy link

commented Feb 11, 2018

Change https://golang.org/cl/93296 mentions this issue: net/http: add missing HTTP status codes

@odeke-em odeke-em changed the title net/http: There are missing HTTP status codes net/http: add 103 and 421 status codes into status.go Feb 11, 2018

@odeke-em

This comment has been minimized.

Copy link
Member

commented Feb 11, 2018

Hello there @ryysud, thank you for raising this issue and welcome to Go!

Interesting, TIL. So from what I can quickly examine:

screen shot 2018-02-11 at 1 58 20 am

  • 421 Misdirected request, perhaps that's a complex interaction with crypto/tls and x/net/http2 so I'll page the wizards @tombergan @bradfitz @agl @rs

@odeke-em odeke-em added this to the Go1.11 milestone Feb 11, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Feb 11, 2018

I'm fine adding 421. Let's wait on 103 until it's finalized.

@ryysud

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2018

@odeke-em
Thank you for your investigation.

@bradfitz
Thank you for the review.
Should I remove 103 from the CL?

@meirf

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2018

FWIW there is some discussion of 421 in #18341, including some comments authored by a definite muggle (me).

@bradfitz

This comment has been minimized.

Copy link
Member

commented Feb 11, 2018

Should I remove 103 from the CL?

Yes.

@ryysud

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2018

@bradfitz I removed 103 from the CL.

@ryysud ryysud changed the title net/http: add 103 and 421 status codes into status.go net/http: add 103 status codes into status.go Feb 12, 2018

@ryysud ryysud changed the title net/http: add 103 status codes into status.go net/http: add 421 status codes into status.go Feb 12, 2018

@gopherbot gopherbot closed this in 4b8a7ea Feb 13, 2018

@golang golang locked and limited conversation to collaborators Feb 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.