/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: better error message for failed string conversion #23813

Open
griesemer opened this Issue Feb 13, 2018 · 2 comments

Comments

Assignees

@odeke-em odeke-em

@griesemer griesemer

Labels
Projects
None yet
Milestone
  Go1.13
3 participants
@griesemer @mdempsky @odeke-em
@griesemer
Contributor

griesemer commented Feb 13, 2018

https://play.golang.org/p/8ADwHokqcK5 complains with:

prog.go:6:12: cannot use x (type []T) as type []byte in argument to runtime.slicebytetostring

The error message should not mention runtime.slicebytetostring which is an implementation detail.

(There are probably more error situations that expose runtime calls this way. Should handle them all uniformly.)

@griesemer griesemer assigned mdempsky Feb 13, 2018

@griesemer griesemer added the NeedsFix label Feb 13, 2018

@griesemer griesemer added this to the Go1.11 milestone Feb 13, 2018

@griesemer griesemer referenced this issue Feb 13, 2018

Open

go/types: incorrect behavior for string conversions of byte slices #23536

@griesemer griesemer assigned griesemer and unassigned mdempsky Jun 5, 2018

@griesemer

This comment has been minimized.

Sign in to view
Contributor

griesemer commented Jun 5, 2018

Has been like this for a while. Moving to 1.12.

@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 5, 2018

@odeke-em odeke-em self-assigned this Oct 18, 2018

@griesemer

This comment has been minimized.

Sign in to view
Contributor

griesemer commented Oct 24, 2018

We should wait with fixing this depending on the resolution of #23536. It's not just go/types. The compiler also seems not consistent.

@griesemer griesemer modified the milestones: Go1.12, Go1.13 Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment