Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: don't post CL updates if the PR author has a Gerrit account #23825

Open
mvdan opened this issue Feb 14, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@mvdan
Copy link
Member

commented Feb 14, 2018

For example: #23809

If gerritbot successfully added the PR author as a reviewer or as CC to the Gerrit CL, it makes little sense to forward comment/review updates to the Github pull request in the form of comments.

@gopherbot gopherbot added this to the Unreleased milestone Feb 14, 2018

@gopherbot gopherbot added the Builders label Feb 14, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Feb 14, 2018

I also suspect we'll need some fancier GitHub email <-> Gerrit email mapping at some point. A good percentage of users have different emails in their Git Author lines vs their Gerrit (Google) account.

@mvdan

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2018

It also seems a bit too spammy if a CL is very active. Assuming that the purpose of these comments is to keep the author notified, I think we should limit them to one per day.

Would also be interesting to not notify about a comment that the author themselves posted, but that seems tricky. If we knew who the author was on Gerrit, we wouldn't be posting the notifications to begin with.

@andybons

This comment has been minimized.

Copy link
Member

commented Feb 14, 2018

It also seems a bit too spammy if a CL is very active. Assuming that the purpose of these comments is to keep the author notified, I think we should limit them to one per day.

It’s unlikely we will implement a digest. This is the exact reason /comments off exists (plus GitHub has its own notification settings).

Agreed that it should default to comments off if the author is also getting emailed in Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.