Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: closing PR doesn't abandon CL #23850

Open
bradfitz opened this issue Feb 15, 2018 · 2 comments

Comments

Projects
None yet
6 participants
@bradfitz
Copy link
Member

commented Feb 15, 2018

This PR was closed by the user:

#23843 (comment)

But GerritBot didn't abandon the CL:

https://go-review.googlesource.com/c/go/+/94315

@bradfitz bradfitz added the NeedsFix label Feb 15, 2018

@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2018

@gopherbot gopherbot added the Builders label Feb 15, 2018

@tklauser

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

Another case: PR golang/sys#8 was closed and https://golang.org/cl/103858 wasn't abandoned.

@dmitshur

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Another occurrence: PR #25817 was closed, but its associated imported Gerrit CL 117795 was not.

I'll aim to resolve this in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.