Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: changes are not seen for refs/meta/config branch #23865

Open
andybons opened this Issue Feb 16, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@andybons
Copy link
Member

andybons commented Feb 16, 2018

This is due to a Gerrit config problem. gobot can’t see a change (https://go-review.googlesource.com/c/go/+/94016) and so it keeps erroring out and causing a 30s backoff.

Is there a reason why we hide our refs/meta/config from the public?

/cc @bradfitz

@andybons andybons self-assigned this Feb 16, 2018

@gopherbot gopherbot added this to the Unreleased milestone Feb 16, 2018

@gopherbot gopherbot added the Builders label Feb 16, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 16, 2018

Change https://golang.org/cl/94615 mentions this issue: cmd/gopherbot: don’t post to CLs in the refs/meta/config branch

gopherbot pushed a commit to golang/build that referenced this issue Feb 16, 2018

cmd/gopherbot: don’t post to CLs in the refs/meta/config branch
Also removes unused b.maxIssueMod field.

Updates golang/go#23865
Change-Id: I4bb3799cbf9f463fa8e99b324f0b2c023422e87e
Reviewed-on: https://go-review.googlesource.com/94615
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Feb 16, 2018

Is there a reason why we hide our refs/meta/config from the public?

I don't think we ever made an explicit decision to do that. Sure that wasn't the default as it was given to us?

@andybons

This comment has been minimized.

Copy link
Member Author

andybons commented Feb 16, 2018

It’s definitely possible. But the person was able to create a change from it so is it visible via git? That would be weird.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Feb 16, 2018

But the person

What person?

@andybons

This comment has been minimized.

Copy link
Member Author

andybons commented Feb 16, 2018

The author of the change linked above.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Feb 16, 2018

Well that's bizarre. No clue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.