Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/websocket: On failed handshake, websocket server closes connection without issuing response. #2396

Closed
gopherbot opened this issue Oct 25, 2011 · 2 comments
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 25, 2011

by marksadamj:

What steps will reproduce the problem?

1. Run a server with the websocket package.
2. Connect to the server and issue an incorrect or incomplete client handshake.

What is the expected output?

Client should see a 4xx HTTP status response.

What do you see instead?

Client sees connection hangup.

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

osx

Which revision are you using?  (hg identify)

6d7136d74b65+ weekly/weekly.2011-10-18

Please provide any additional information below.

The code appears to be originating and passing around http statuses, but they are not
getting out onto the response.
@ukai
Copy link
Contributor

@ukai ukai commented Nov 2, 2011

Comment 1:

Thanks for the report.
I missed recent websocket spec had changed that the server needs to return an http
response with an appropriate error code.
I'll fix it soon.
@adg
Copy link
Contributor

@adg adg commented Nov 7, 2011

Comment 2:

http://code.google.com/p/go/source/detail?r=487aea019d10

Status changed to Fixed.

@gopherbot gopherbot added fixed labels Nov 7, 2011
@mikioh mikioh changed the title On failed handshake, websocket server closes connection without issuing response. x/net/websocket: On failed handshake, websocket server closes connection without issuing response. Jul 30, 2015
@mikioh mikioh modified the milestone: Unreleased Jul 30, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.