Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: should comments be supported in go.mod? #23976

Closed
pdk opened this issue Feb 21, 2018 · 1 comment
Closed

x/vgo: should comments be supported in go.mod? #23976

pdk opened this issue Feb 21, 2018 · 1 comment
Milestone

Comments

@pdk
Copy link

@pdk pdk commented Feb 21, 2018

Often when there is a particular requirement or exclusion, there is likely to be commentary about why/why not, and information about when it may be changed. E.g.

// Before upgrading to a newer sampler, make sure "99 bottles" is resolved. (pdk)
exclude "rsc.io/sampler" v1.99.99
@davecheney davecheney changed the title should comments be supported in mod.go? x/vgo: should comments be supported in go.mod? Feb 21, 2018
@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2018
@pdk

This comment has been minimized.

Copy link
Author

@pdk pdk commented Feb 21, 2018

Whoops. Already supported. Just no mention in blog posts.

@pdk pdk closed this Feb 21, 2018
@golang golang locked and limited conversation to collaborators Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.