Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: cannot require k8s.io/client-go v6.0.0 #23980

Closed
davecheney opened this issue Feb 21, 2018 · 3 comments

Comments

@davecheney
Copy link
Contributor

commented Feb 21, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.10

Does this issue reproduce with the latest release?

n/a

What operating system and processor architecture are you using (go env)?

darwin/amd64

What did you do?

Daves-MacBook-Pro(~/src/github.com/heptio/contour) % cat go.mod
module "github.com/heptio/contour"

require (
        "k8s.io/client-go" v6.0.0
)

What did you expect to see?

Build success (or at least fetching of the v6.0.0 tag) then probably blowing up with something else

What did you see instead?

Daves-MacBook-Pro(~/src/github.com/heptio/contour) % vgo build ./cmd/contour
vgo: errors parsing go.mod:
/Users/dfc/src/github.com/heptio/contour/go.mod:4: invalid module: k8s.io/client-go should be v1, not v6 (v6.0.0)

@gopherbot gopherbot added this to the vgo milestone Feb 21, 2018

@mvdan

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

Possibly the same as #23977? If that bug is correct, only v1 and v2 should currently work.

@mikkeloscar

This comment has been minimized.

Copy link

commented Feb 23, 2018

For anyone interested. A quick workaround is to use the commit:

require (
        "k8s.io/client-go" v0.0.0-20171206195300-78700dec6369ba22221b72770783300f143df150
)
@davecheney

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2018

Duplicate of #23977

There are many discussions on the inclusion of the /v_N_ component in the import path. There doesn't need to be another issue for the discussion to leak onto.

@davecheney davecheney closed this Feb 24, 2018

@golang golang locked and limited conversation to collaborators Feb 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.