Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: gopkg.in repos that use tags not branches do not work #23991

Closed
rogpeppe opened this issue Feb 21, 2018 · 1 comment

Comments

@rogpeppe
Copy link
Contributor

commented Feb 21, 2018

% vgo version
go version devel +104445e Wed Feb 7 19:22:09 2018 +0000 linux/amd64 vgo:2018-02-20.1

Some gopkg.in repos use tags instead of branches to tag the major versions.
Here's one example:

% cat xx.go
package main // import "github.com/rogpeppe/xx"

import (
	_ "gopkg.in/natefinch/lumberjack.v2"
)

func main() {
}
% vgo build
vgo: resolving import "gopkg.in/natefinch/lumberjack.v2"
vgo: import "github.com/rogpeppe/xx" ->
	import "gopkg.in/natefinch/lumberjack.v2": unexpected status (https://api.github.com/repos/natefinch/lumberjack/commits?sha=v2&until=2018-02-21T09%3A22%3A29Z&per_page=2): 404 Not Found

@gopherbot gopherbot added this to the vgo milestone Feb 21, 2018

@rsc rsc added the NeedsFix label Apr 2, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Apr 18, 2018

Change https://golang.org/cl/107658 mentions this issue: cmd/go/internal/modfetch: make gopkg.in support more seamless

@golang golang locked and limited conversation to collaborators Apr 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.